-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of copy_if_else for long strings #15017
Improve performance of copy_if_else for long strings #15017
Conversation
Benchmark results show significant improvement for long strings.
Small strings suffer a bit but most are within 1-2 ms of the baseline. |
This looks great thanks so much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice! It also makes the code simpler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change: higher throughput, less code!
Some minor suggestions.
/merge |
Description
Reworks the
cudf::strings::detail::copy_if_else()
to improve performance for long strings. The rework builds a vector of rows to pass to themake_strings_column
factory that uses the optimizedgather_chars
function.Also includes a benchmark for copy_if_else specifically for strings columns.
Closes #15014
Checklist