Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add developer guideline to use east const. #14836

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Add developer guideline to use east const. #14836

merged 1 commit into from
Jan 23, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 23, 2024

Description

This PR documents the libcudf preference for "east const." Follow-up from #13491, #13492, #13493, #13494.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner January 23, 2024 14:39
@bdice bdice requested review from ttnghia and PointKernel January 23, 2024 14:39
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jan 23, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change labels Jan 23, 2024
@bdice
Copy link
Contributor Author

bdice commented Jan 23, 2024

/merge

@rapids-bot rapids-bot bot merged commit bb02514 into rapidsai:branch-24.04 Jan 23, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@PointKernel PointKernel PointKernel approved these changes

@ttnghia ttnghia ttnghia approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdice @ttnghia @PointKernel @davidwendt