Use east const in include files #13494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikeyann
added
3 - Ready for Review
This was referenced Jun 1, 2023
ttnghia
approved these changes
Jun 1, 2023
PointKernel
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Not for this PR but this should be a cuh file instead of c-style h file.
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 6, 2023
Use east const in _cpp/tests/_ files used clang-format `QualifierAlignment: Right` to do the clean up. since https://clang.llvm.org/docs/ClangFormatStyleOptions.html#qualifieralignment has warning that `Setting QualifierAlignment to something other than Leave, COULD lead to incorrect code formatting due to incorrect decisions made due to clang-formats lack of complete semantic information. As such extra care should be taken to review code changes made by the use of this option.` So it's not added to .clang-format Split to multiple PRs for easy reviewing #13491, #13492, #13493, #13494 Authors: - Karthikeyan (https://github.com/karthikeyann) Approvers: - Nghia Truong (https://github.com/ttnghia) - Mark Harris (https://github.com/harrism) URL: #13492
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 10, 2023
Use east const in _cpp/src/_ files used clang-format `QualifierAlignment: Right` to do the clean up. since https://clang.llvm.org/docs/ClangFormatStyleOptions.html#qualifieralignment has warning that `Setting QualifierAlignment to something other than Leave, COULD lead to incorrect code formatting due to incorrect decisions made due to clang-formats lack of complete semantic information. As such extra care should be taken to review code changes made by the use of this option.` So it's not added to .clang-format Split to multiple PRs for easy reviewing #13491, #13492, #13493, #13494 Authors: - Karthikeyan (https://github.com/karthikeyann) Approvers: - Nghia Truong (https://github.com/ttnghia) - Vukasin Milovanovic (https://github.com/vuule) URL: #13493
karthikeyann
changed the title
karthikeyann
changed the title
vyasr
approved these changes
Jun 13, 2023
karthikeyann
changed the title
karthikeyann
changed the title
karthikeyann
changed the title
karthikeyann
added
5 - Ready to Merge
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
Use east const in _cpp/benchmarks/_ files used clang-format `QualifierAlignment: Right` to do the clean up. since https://clang.llvm.org/docs/ClangFormatStyleOptions.html#qualifieralignment has warning that `Setting QualifierAlignment to something other than Leave, COULD lead to incorrect code formatting due to incorrect decisions made due to clang-formats lack of complete semantic information. As such extra care should be taken to review code changes made by the use of this option.` So it's not added to .clang-format Split to multiple PRs for easy reviewing #13491, #13492, #13493, #13494 Authors: - Karthikeyan (https://github.com/karthikeyann) - Nghia Truong (https://github.com/ttnghia) Approvers: - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) URL: #13491
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 23, 2024
This PR documents the libcudf preference for "east const." Follow-up from #13491, #13492, #13493, #13494. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - David Wendt (https://github.com/davidwendt) - Nghia Truong (https://github.com/ttnghia) - Yunsong Wang (https://github.com/PointKernel) URL: #14836
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use east const in cpp/include/ files
used clang-format
QualifierAlignment: Rightto do the clean up.since https://clang.llvm.org/docs/ClangFormatStyleOptions.html#qualifieralignment has warning that
Setting QualifierAlignment to something other than Leave, COULD lead to incorrect code formatting due to incorrect decisions made due to clang-formats lack of complete semantic information. As such extra care should be taken to review code changes made by the use of this option.So it's not added to .clang-format
Split to multiple PRs for easy reviewing #13491, #13492, #13493, #13494
Checklist