Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rapids_cuda_set_runtime to determine cuda runtime usage by target #14833

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Use rapids_cuda_set_runtime to determine cuda runtime usage by target #14833

merged 4 commits into from
Jan 23, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jan 23, 2024

Description

This PR uses rapids-cmake to handle per-target CMake linking to cudart.

Replaces #13543 and #11641.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 23, 2024
@vyasr vyasr self-assigned this Jan 23, 2024
@vyasr vyasr requested a review from a team as a code owner January 23, 2024 00:11
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jan 23, 2024
This was referenced Jan 23, 2024
Closed
Closed
robertmaynard
robertmaynard requested changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cudftestutil and the tests will also need to be updated to use rapids_cuda_set_runtime since they aren't transitively going to anything propagated from cudf::cudf

@vyasr vyasr requested a review from a team as a code owner January 23, 2024 18:06
@vyasr
Copy link
Contributor Author

vyasr commented Jan 23, 2024

/merge

@rapids-bot rapids-bot bot merged commit 16a942d into rapidsai:branch-24.04 Jan 23, 2024
67 checks passed
@vyasr vyasr deleted the feat/rapids_cuda_set_runtime branch January 23, 2024 21:15
PointKernel pushed a commit to PointKernel/cudf that referenced this pull request Jan 25, 2024
@vyasr @PointKernel
Use rapids_cuda_set_runtime to determine cuda runtime usage by targ…
fb4ac33 
…et (rapidsai#14833)

This PR uses rapids-cmake to handle per-target CMake linking to cudart.

Replaces rapidsai#13543 and rapidsai#11641.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Robert Maynard (https://github.com/robertmaynard)

URL: rapidsai#14833
@davidwendt davidwendt mentioned this pull request Jan 25, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@vuule vuule Awaiting requested review from vuule vuule is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vyasr vyasr

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @robertmaynard @harrism