Use rapids_init_cuda_runtime. #13543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CMake
robertmaynard
requested changes
Jun 9, 2023
| @@ -710,18 +714,6 @@ if(TARGET conda_env) | |||
| target_link_libraries(cudf PRIVATE conda_env) | |||
| endif() | |||
|
|
|||
| if(CUDA_STATIC_RUNTIME) | |||
There was a problem hiding this comment.
We will still need
if(CUDA_STATIC_RUNTIME AND NOT BUILD_SHARED_LIBS )
# Make sure to export to consumers what runtime we used
target_link_libraries(cudf PUBLIC CUDA::cudart_static)
endif()
since when doing static linking libcudf won't have linked to the cuda runtime and so we need to tell the consumer that is the intent. 
3 tasks
|
Closing in favor of #14833 |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 23, 2024
…et (#14833) This PR uses rapids-cmake to handle per-target CMake linking to cudart. Replaces #13543 and #11641. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Mark Harris (https://github.com/harrism) - Robert Maynard (https://github.com/robertmaynard) URL: #14833
PointKernel
pushed a commit
to PointKernel/cudf
that referenced
this pull request
Jan 25, 2024
…et (rapidsai#14833) This PR uses rapids-cmake to handle per-target CMake linking to cudart. Replaces rapidsai#13543 and rapidsai#11641. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Mark Harris (https://github.com/harrism) - Robert Maynard (https://github.com/robertmaynard) URL: rapidsai#14833
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates libcudf to use
rapids_init_cuda_runtime.Checklist