Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement to_datetime(..., utc=True) #14749

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Implement to_datetime(..., utc=True) #14749

merged 3 commits into from
Jan 22, 2024

Conversation

mroeschke
Copy link
Contributor

Description

closes #13661

Also added typing and fixes a bug where uint data would raise a TypeError

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 11, 2024
@mroeschke mroeschke requested a review from a team as a code owner January 11, 2024 22:24
@mroeschke mroeschke requested review from wence- and shwina January 11, 2024 22:24
shwina
shwina approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mroeschke!

@shwina
Copy link
Contributor

shwina commented Jan 22, 2024

/merge

@rapids-bot rapids-bot bot merged commit d1c0e25 into rapidsai:branch-24.02 Jan 22, 2024
67 checks passed
@mroeschke mroeschke deleted the enh/to_datetime/utc branch January 22, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] cudf.to_datetime() ignores utc= argument
2 participants
@mroeschke @shwina