Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] cudf.to_datetime() ignores utc= argument #13661

Closed
shwina opened this issue Jul 5, 2023 · 0 comments · Fixed by #14749
Closed

[BUG] cudf.to_datetime() ignores utc= argument #13661

shwina opened this issue Jul 5, 2023 · 0 comments · Fixed by #14749
Labels
bug Something isn't working Python Affects Python cuDF API.

Comments

@shwina
Copy link
Contributor

shwina commented Jul 5, 2023

Now that we support timezone aware types, we should properly handle the utc= argument:

In [3]: pd.to_datetime(['2001-01-01'], utc=True)
Out[3]: DatetimeIndex(['2001-01-01 00:00:00+00:00'], dtype='datetime64[ns, UTC]', freq=None)

In [4]: cudf.to_datetime(['2001-01-01'], utc=True)
Out[4]: DatetimeIndex(['2001-01-01'], dtype='datetime64[ns]')
@shwina shwina added bug Something isn't working Needs Triage Need team to review and classify Python Affects Python cuDF API. and removed Needs Triage Need team to review and classify labels Jul 5, 2023
@shwina shwina mentioned this issue Jul 7, 2023
Merged
rapids-bot bot pushed a commit that referenced this issue Jul 10, 2023
@shwina
Raise a NotImplementedError in to_datetime when utc is passed (#13670)
964925a 
While we figure out a solution for #13661, this PR ensures that we correctly raise a `NotImplementedError`.

Authors:
  - Ashwin Srinath (https://github.com/shwina)

Approvers:
  - Matthew Roeschke (https://github.com/mroeschke)

URL: #13670
@mroeschke mroeschke mentioned this issue Jan 11, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Jan 22, 2024
@mroeschke
Implement to_datetime(..., utc=True) (#14749)
d1c0e25 
closes #13661

Also added typing and fixes a bug where `uint` data would raise a TypeError

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Ashwin Srinath (https://github.com/shwina)

URL: #14749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement to_datetime(..., utc=True) mroeschke/cudf
1 participant
@shwina