Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary **kwargs in function signatures #14635

Merged
merged 11 commits into from
Jan 12, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Helps makes function signatures stricter to avoid typo inputs being accepted into signatures

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 14, 2023
@mroeschke mroeschke requested a review from a team as a code owner December 14, 2023 21:47
@vyasr
Copy link
Contributor

vyasr commented Jan 11, 2024

@mroeschke can you update this PR and fix the copyrights? I'd like to see a full test run before approving just to be sure nothing was relying on passing in unused arguments for args/kwargs to toss away.

@vyasr
Copy link
Contributor

vyasr commented Jan 12, 2024

/merge

@rapids-bot rapids-bot bot merged commit 9937c7f into rapidsai:branch-24.02 Jan 12, 2024
68 checks passed
@mroeschke mroeschke deleted the ref/remove_kwargs branch January 12, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants