Add string.convert.convert_integers APIs to pylibcudf #16991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
improvement
|
Needs conflict resolution now. |
…trings/convert_intergers
…trings/convert_intergers
charlesbluca
previously requested changes
Oct 8, 2024
charlesbluca
reviewed
Oct 8, 2024
Co-authored-by: Charles Blackmon-Luca <[email protected]>
…trings/convert_intergers
…trings/convert_intergers
vyasr
approved these changes
Oct 9, 2024
|
Needs another round of conflict resolution |
Thanks done. I also found more place I was able to apply your suggestion in #16991 (comment) to use more |
brandon-b-miller
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Addressed my own suggestion about libcudf_exception_handler pre-emptively. @charlesbluca any final thoughts here?
Matt711
approved these changes
Oct 14, 2024
|
Since this has a few approvals and is only introducing fairly in-pattern additional functionality I'm going to move forward with merging here. |
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
Depends on #16991 Part of #17060 Implements cross casting from string <-> numeric types in `cudf-polars` Authors: - https://github.com/brandon-b-miller - Matthew Murray (https://github.com/Matt711) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Lawrence Mitchell (https://github.com/wence-) - Muhammad Haseeb (https://github.com/mhaseeb123) - Matthew Murray (https://github.com/Matt711) URL: #17076
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #15162
Checklist