Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cuda::proclaim_return_type from nested lambda #14607

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Remove cuda::proclaim_return_type from nested lambda #14607

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb844a8
Remove `proclaim_return_type` from lambda
ttnghia Dec 10, 2023
d9b7cbe
Add comment
ttnghia Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions cpp/src/quantiles/tdigest/tdigest_aggregation.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,15 +587,16 @@ std::unique_ptr<column> build_output_column(size_type num_rows,
auto is_stub_weight = [weights = weights->view().begin<double>()] __device__(size_type i) {
return weights[i] == 0;
};
// whether or not this particular tdigest is a stub
auto is_stub_digest = cuda::proclaim_return_type<size_type>(
[offsets = offsets->view().begin<size_type>(), is_stub_weight] __device__(size_type i) {
return is_stub_weight(offsets[i]) ? 1 : 0;
});
// Whether or not this particular tdigest is a stub.
// This should not be wrapped in `proclaim_return_type` as it will be used inside another
// device lambda.
auto is_stub_digest = [offsets = offsets->view().begin<size_type>(), is_stub_weight] __device__(
ttnghia marked this conversation as resolved.
Show resolved Hide resolved
size_type i) { return is_stub_weight(offsets[i]) ? 1 : 0; };

size_type const num_stubs = [&]() {
if (!has_nulls) { return 0; }
auto iter = cudf::detail::make_counting_transform_iterator(0, is_stub_digest);
auto iter = cudf::detail::make_counting_transform_iterator(
0, cuda::proclaim_return_type<size_type>(is_stub_digest));
return thrust::reduce(rmm::exec_policy(stream), iter, iter + num_rows);
}();

Expand Down