Remove cuda::proclaim_return_type from nested lambda
#14607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Truong <[email protected]>
ttnghia
added
bug
ttnghia
commented
Dec 10, 2023
miscco
approved these changes
Dec 11, 2023
Signed-off-by: Nghia Truong <[email protected]>
karthikeyann
approved these changes
Dec 11, 2023
nvdbaranec
approved these changes
Dec 11, 2023
bdice
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
I confirmed that #14576 builds with this change. I noted in #14610 that we should file an issue with CCCL that documents the compiler versions / etc. used to trigger this error, with a minimal reproduction (especially since RAPIDS CI doesn't complain). The proclaim_return_type wrapper should not break normal device lambda compilation.
|
/merge |
karthikeyann
pushed a commit
to karthikeyann/cudf
that referenced
this pull request
Dec 12, 2023
This removes `cuda::proclaim_return_type` from a device lambda because that lambda is going to be nested inside another device lambda, which is in turn enclosed by `cuda::proclaim_return_type`.
This PR is to fix a compile issue that we encountered:
```
/usr/local/cuda/include/cuda/std/detail/libcxx/include/__functional/invoke.h(402): error:
calling a __device__ function("cudf::tdigest::detail::_NV_ANON_NAMESPACE::build_output_column(int,
::std::unique_ptr< ::cudf::column, ::std::default_delete< ::cudf::column> > &&, ::std::unique_ptr< ::cudf::column, ::std::default_delete< ::cudf::column> > &&, ::std::unique_ptr< ::cudf::column, ::std::default_delete< ::cudf::column> > &&, ::std::unique_ptr< ::cudf::column, ::std::default_delete< ::cudf::column> > &&, ::std::unique_ptr< ::cudf::column, ::std::default_delete< ::cudf::column> > &&, bool, ::rmm::cuda_stream_view, ::rmm::mr::device_memory_resource *)
::[lambda(int) (instance 2)]::operator ()(int) const") from a __host__ __device__ function("__invoke") is not allowed
```
Note: The issue is reproducible only in our build environment: ARM architecture, cuda 12 + rockylinux8.
Closes rapidsai#14610.
Authors:
- Nghia Truong (https://github.com/ttnghia)
Approvers:
- Michael Schellenberger Costa (https://github.com/miscco)
- Karthikeyan (https://github.com/karthikeyann)
- https://github.com/nvdbaranec
- Bradley Dice (https://github.com/bdice)
URL: rapidsai#14607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
cuda::proclaim_return_typefrom a device lambda because that lambda is going to be nested inside another device lambda, which is in turn enclosed bycuda::proclaim_return_type.This PR is to fix a compile issue that we encountered:
Note: The issue is reproducible only in our build environment: ARM architecture, cuda 12 + rockylinux8.
Closes #14610.