Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsanitized input test data from copy gtests #14600

Merged
merged 1 commit into from
Dec 12, 2023
+3 −14
Merged

Remove unsanitized input test data from copy gtests #14600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions cpp/tests/copying/copy_if_else_nested_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,22 +386,12 @@ TYPED_TEST(TypedCopyIfElseNestedTest, ScalarListBothInvalid)
using bools = cudf::test::fixed_width_column_wrapper<bool, int32_t>;
using lcw = cudf::test::lists_column_wrapper<T, int32_t>;

auto lhs_scalar = cudf::list_scalar{ints{33, 33, 33}, false};
auto rhs_scalar = cudf::list_scalar{ints{22, 22}, false};
auto lhs_scalar = cudf::list_scalar{ints{}, false};
auto rhs_scalar = cudf::list_scalar{ints{}, false};

auto selector_column = bools{1, 1, 0, 1, 1, 0, 1}.release();

auto expected = lcw{{
{-33, -33, -33},
{-33, -33, -33},
{-22, -22},
{-33, -33, -33},
{-33, -33, -33},
{-22, -22},
{-33, -33, -33},
},
all_nulls()}
.release();
auto expected = lcw{{lcw{}, lcw{}, lcw{}, lcw{}, lcw{}, lcw{}, lcw{}}, all_nulls()}.release();

auto result = cudf::copy_if_else(lhs_scalar, rhs_scalar, selector_column->view());

Expand Down
1 change: 0 additions & 1 deletion cpp/tests/copying/purge_nonempty_nulls_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ struct PurgeNonEmptyNullsTest : public cudf::test::BaseFixture {
void test_purge(cudf::column_view const& unpurged)
{
auto const purged = cudf::purge_nonempty_nulls(unpurged);
CUDF_TEST_EXPECT_COLUMNS_EQUIVALENT(unpurged, *purged);
EXPECT_FALSE(cudf::has_nonempty_nulls(*purged));
}
};
Expand Down