Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unsanitized input test data from copy gtests #14600

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Remove unsanitized input test data from copy gtests #14600

merged 1 commit into from
Dec 12, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Removes unsanitized rows from input data in gtests for COPYING_TEST.
This fixes some errors found in #14559

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Dec 8, 2023
@davidwendt davidwendt self-assigned this Dec 8, 2023
@davidwendt davidwendt requested a review from a team as a code owner December 8, 2023 18:59
@vyasr
Copy link
Contributor

vyasr commented Dec 12, 2023

/merge

@rapids-bot rapids-bot bot merged commit 1c6f80d into rapidsai:branch-24.02 Dec 12, 2023
67 checks passed
karthikeyann pushed a commit to karthikeyann/cudf that referenced this pull request Dec 12, 2023
@davidwendt @karthikeyann
Remove unsanitized input test data from copy gtests (rapidsai#14600)
404a909 
Removes unsanitized rows from input data in gtests for COPYING_TEST.
This fixes some errors found in rapidsai#14559

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Karthikeyan (https://github.com/karthikeyann)

URL: rapidsai#14600
@davidwendt davidwendt deleted the fix-unsanitized-gtests branch February 5, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyann karthikeyann karthikeyann approved these changes

@bdice bdice bdice approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @vyasr @bdice @karthikeyann