Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move non-templated inline function definitions from table_view.hpp to table_view.cpp #14535

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Move non-templated inline function definitions from table_view.hpp to table_view.cpp #14535

merged 2 commits into from
Dec 5, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Moves some inline functions from the table_view.hpp to the table_view.cpp to help reduce dependency bloat.
Also reference #14531: I'd like to minimize changes to the highly inclusive table_view.hpp.

Closes #14431

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 30, 2023
@davidwendt davidwendt self-assigned this Nov 30, 2023
@davidwendt davidwendt requested a review from a team as a code owner November 30, 2023 14:08
@davidwendt
Copy link
Contributor Author

Also, I did not find any other similar candidate inline functions after doing a general search of the source code.

@davidwendt davidwendt requested a review from bdice November 30, 2023 14:10
@hyperbolic2346
Copy link
Contributor

Are we concerned about the performance implications of removing the ability to inline these functions? I only ask because that is the assumed reason they were there in the first place.

@davidwendt
Copy link
Contributor Author

davidwendt commented Dec 5, 2023 •
edited
Loading

I'm not concerned about inlining CPU code. These in particular should be negligible.

karthikeyann
karthikeyann approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 8f7cbe6 into rapidsai:branch-24.02 Dec 5, 2023
67 checks passed
@davidwendt davidwendt deleted the refactor-inline branch December 5, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyann karthikeyann karthikeyann approved these changes

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@vyasr vyasr vyasr approved these changes

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@bdice bdice Awaiting requested review from bdice

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move non-templated inline function definitions from table_view.hpp to source file
4 participants
@davidwendt @hyperbolic2346 @vyasr @karthikeyann