Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move non-templated inline function definitions from table_view.hpp to source file #14431

Closed
divyegala opened this issue Nov 16, 2023 · 0 comments · Fixed by #14535
Closed

Move non-templated inline function definitions from table_view.hpp to source file #14431

divyegala opened this issue Nov 16, 2023 · 0 comments · Fixed by #14535
Assignees
@davidwendt

Comments

@divyegala
Copy link
Member

Reference comment: #14363 (comment)_

It is possibly worth an effort to sweep through the codebase to find other spots that may benefit from such refactoring as well.
@divyegala divyegala mentioned this issue Nov 16, 2023
Merged
3 tasks
@davidwendt davidwendt self-assigned this Nov 29, 2023
@davidwendt davidwendt mentioned this issue Nov 30, 2023
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Dec 5, 2023
@davidwendt
Move non-templated inline function definitions from table_view.hpp to…
8f7cbe6 
… table_view.cpp (#14535)

Moves some `inline` functions from the `table_view.hpp` to the `table_view.cpp` to help reduce dependency bloat.
Also reference #14531: I'd like to minimize changes to the highly inclusive `table_view.hpp`.

Closes #14431

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Karthikeyan (https://github.com/karthikeyann)
  - Mike Wilson (https://github.com/hyperbolic2346)

URL: #14535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwendt davidwendt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move non-templated inline function definitions from table_view.hpp to table_view.cpp davidwendt/cudf
2 participants
@divyegala @davidwendt