Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codecov coverage for pandas_tests #14513

Merged
merged 18 commits into from
Jun 14, 2024
Merged

Add codecov coverage for pandas_tests #14513

merged 18 commits into from
Jun 14, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #14496

This PR enables code-coverage for pandas tests that are run in cudf CI in pandas accelerator mode.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 28, 2023
@galipremsagar galipremsagar self-assigned this Nov 28, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner November 28, 2023 15:58
@github-actions github-actions bot added the ci label Nov 28, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner November 28, 2023 17:26
@galipremsagar galipremsagar changed the base branch from branch-24.02 to branch-23.12 November 28, 2023 17:26
@github-actions github-actions bot added Python Affects Python cuDF API. and removed ci labels Nov 28, 2023
@galipremsagar galipremsagar requested review from a team as code owners November 28, 2023 17:35
@galipremsagar galipremsagar requested review from harrism and davidwendt and removed request for a team November 28, 2023 17:35
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 28, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@galipremsagar galipremsagar changed the base branch from branch-23.12 to branch-24.02 November 28, 2023 17:35
@github-actions github-actions bot added ci and removed Python Affects Python cuDF API. labels Nov 28, 2023
@galipremsagar galipremsagar changed the base branch from branch-24.02 to branch-24.06 April 9, 2024 21:10
@galipremsagar
Copy link
Contributor Author

/okay to test

bdice
bdice approved these changes Apr 9, 2024
View reviewed changes
ci/cudf_pandas_scripts/run_tests.sh Outdated Show resolved Hide resolved
@galipremsagar
Copy link
Contributor Author

/okay to test

@vyasr vyasr requested a review from a team as a code owner May 21, 2024 18:21
@vyasr
Copy link
Contributor

vyasr commented May 21, 2024

@galipremsagar should we go ahead and get this merged?

@galipremsagar
Copy link
Contributor Author

@galipremsagar should we go ahead and get this merged?

Running with codecov was inserting some new frames that are interfering with our profiler. I'll monitor this CI run, if I'm not able to resolve this by EOD, I'll move this to 24.08

@github-actions github-actions bot added the Python Affects Python cuDF API. label May 22, 2024
@vyasr vyasr removed the ci label Jun 3, 2024
@charlesbluca
Copy link
Member

cc @galipremsagar checking in here - any remaining blockers here, or could this be retargeted and merged into 24.08?

@galipremsagar galipremsagar changed the base branch from branch-24.06 to branch-24.08 June 14, 2024 14:59
@github-actions github-actions bot added the cudf.pandas Issues specific to cudf.pandas label Jun 14, 2024
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit f89cc07 into rapidsai:branch-24.08 Jun 14, 2024
75 checks passed
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@wence- wence- wence- approved these changes

@ajschmidt8 ajschmidt8 Awaiting requested review from ajschmidt8

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge cudf.pandas Issues specific to cudf.pandas improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] codecov doesn't include tests run in cudf_pandas_tests/ when generating report
6 participants
@galipremsagar @vyasr @charlesbluca @wence- @bdice @ajschmidt8