Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] codecov doesn't include tests run in cudf_pandas_tests/ when generating report #14496

Closed
shwina opened this issue Nov 27, 2023 · 0 comments · Fixed by #14513
Closed

[BUG] codecov doesn't include tests run in cudf_pandas_tests/ when generating report #14496

shwina opened this issue Nov 27, 2023 · 0 comments · Fixed by #14513
Assignees
@galipremsagar
Labels
bug Something isn't working cudf.pandas Issues specific to cudf.pandas Python Affects Python cuDF API.
Milestone
cudf.pandas API c...

Comments

@shwina
Copy link
Contributor

shwina commented Nov 27, 2023

The codecov report generated in every PR doesn't consider the tests in cudf_pandas_tests/ when generating its coverage report. To fix this, we should update our invocation here:

https://github.com/rapidsai/cudf/blob/branch-24.02/ci/cudf_pandas_scripts/run_tests.sh#L52

to match the ones we use when running other python tests:

https://github.com/rapidsai/cudf/blob/branch-24.02/ci/test_python_cudf.sh#L17

(in particular, all the --cov* arguments)
@shwina shwina added bug Something isn't working Needs Triage Need team to review and classify ci Python Affects Python cuDF API. and removed Needs Triage Need team to review and classify labels Nov 27, 2023
@galipremsagar galipremsagar self-assigned this Nov 27, 2023
@galipremsagar galipremsagar mentioned this issue Nov 28, 2023
Merged
3 tasks
@galipremsagar galipremsagar added the cudf.pandas Issues specific to cudf.pandas label Apr 15, 2024
@vyasr vyasr removed the pandas label May 16, 2024
@vyasr vyasr removed the ci label Jun 3, 2024
@GPUtester GPUtester moved this to In Progress in cuDF Python Jun 14, 2024
rapids-bot bot pushed a commit that referenced this issue Jun 14, 2024
@galipremsagar
Add codecov coverage for pandas_tests (#14513)
f89cc07 
Fixes: #14496 

This PR enables code-coverage for `pandas` tests that are run in cudf CI in pandas accelerator mode.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Lawrence Mitchell (https://github.com/wence-)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Lawrence Mitchell (https://github.com/wence-)

URL: #14513
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuDF Python Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galipremsagar galipremsagar

Labels
bug Something isn't working cudf.pandas Issues specific to cudf.pandas Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
cudf.pandas API coverage
Development

Successfully merging a pull request may close this issue.

Add codecov coverage for pandas_tests galipremsagar/cudf
3 participants
@vyasr @shwina @galipremsagar