Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove null mask for zero nulls in json readers #14451

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Remove null mask for zero nulls in json readers #14451

merged 4 commits into from
Dec 7, 2023

Conversation

karthikeyann
Copy link
Contributor

Description

Closes #14366
Removes null mask for zero nulls in json readers (nested json reader and legacy json reader in gpu)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@karthikeyann karthikeyann added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond cuIO cuIO issue 4 - Needs cuIO Reviewer Performance Performance related issue improvement Improvement / enhancement to an existing function breaking Breaking change labels Nov 19, 2023
@karthikeyann karthikeyann self-assigned this Nov 19, 2023
@karthikeyann karthikeyann marked this pull request as ready for review November 22, 2023 05:34
@karthikeyann karthikeyann requested a review from a team as a code owner November 22, 2023 05:34
@karthikeyann karthikeyann mentioned this pull request Nov 22, 2023
Closed
@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Nov 22, 2023
hyperbolic2346
hyperbolic2346 requested changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@hyperbolic2346 hyperbolic2346 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple comments

cpp/src/io/json/nested_json_gpu.cu Outdated Show resolved Hide resolved
cpp/tests/io/json_test.cpp Outdated Show resolved Hide resolved
@karthikeyann
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit a253826 into rapidsai:branch-24.02 Dec 7, 2023
67 checks passed
karthikeyann added a commit to karthikeyann/cudf that referenced this pull request Dec 12, 2023
@karthikeyann
Remove null mask for zero nulls in json readers (rapidsai#14451)
ee0dbbe 
Closes  rapidsai#14366
Removes null mask for zero nulls in json readers (nested json reader and legacy json reader in gpu)

Authors:
  - Karthikeyan (https://github.com/karthikeyann)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Mike Wilson (https://github.com/hyperbolic2346)

URL: rapidsai#14451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@divyegala divyegala Awaiting requested review from divyegala

Assignees

@karthikeyann karthikeyann

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond breaking Breaking change cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. Performance Performance related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON reader provides a full null mask for a column with no NULLs
4 participants
@karthikeyann @hyperbolic2346 @ttnghia @vyasr