Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use isinstance(..., cudf.CategoricalDtype) instead of is_categorical_dtype #14423

Merged
merged 7 commits into from
Dec 7, 2023
Merged

Use isinstance(..., cudf.CategoricalDtype) instead of is_categorical_dtype #14423

merged 7 commits into from
Dec 7, 2023

Conversation

mroeschke
Copy link
Contributor

Description

Helps the code base be more-strict about checking cudf.CategoricalDtype and not accidentally allowing pd.CategoricalDtype or "category"

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 16, 2023
@mroeschke mroeschke requested a review from a team as a code owner November 16, 2023 02:51
@mroeschke mroeschke changed the title REF: Use isinstance(..., cudf.CategoricalDtype) instead of is_categorical_dtype Use isinstance(..., cudf.CategoricalDtype) instead of is_categorical_dtype Nov 28, 2023
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 93db3b8 into rapidsai:branch-24.02 Dec 7, 2023
65 checks passed
@mroeschke mroeschke deleted the ref/is_categorical_dtype branch December 7, 2023 21:28
karthikeyann pushed a commit to karthikeyann/cudf that referenced this pull request Dec 12, 2023
@mroeschke @karthikeyann
Use isinstance(..., cudf.CategoricalDtype) instead of is_categorical_…
eaba945 
…dtype (rapidsai#14423)

Helps the code base be more-strict about checking `cudf.CategoricalDtype` and not accidentally allowing `pd.CategoricalDtype` or `"category"`

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

URL: rapidsai#14423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @galipremsagar