Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and report errors in Parquet header parsing #14237

Merged
merged 33 commits into from
Oct 20, 2023
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
6457f03
remove unneeded cruft from thrift parser
etseidl Sep 29, 2023
854916b
report errors parsing page headers
etseidl Sep 29, 2023
34ca06a
Merge branch 'rapidsai:branch-23.12' into detect_header_overrun
etseidl Sep 29, 2023
e50515a
add test
etseidl Sep 29, 2023
7486d8b
Merge branch 'detect_header_overrun' of github.com:etseidl/cudf into …
etseidl Sep 29, 2023
74e0867
Merge branch 'branch-23.12' into detect_header_overrun
etseidl Oct 3, 2023
7a4d1cb
implement suggestion from review
etseidl Oct 3, 2023
2f299a0
add some braces
etseidl Oct 3, 2023
adc5f2c
check for errors before checking returned value
etseidl Oct 3, 2023
0f086a8
create a shared error scalar
etseidl Oct 4, 2023
5573c64
rework error stuff some to pass python tests
etseidl Oct 4, 2023
3ec7225
Merge branch 'branch-23.12' into detect_header_overrun
etseidl Oct 4, 2023
50e4efc
use set_error
etseidl Oct 4, 2023
62a1f85
switch to new error reporting
etseidl Oct 4, 2023
50314f3
detect unsupported page encodings in kernel now
etseidl Oct 4, 2023
f75884c
get rid of global error and instead wrap it
etseidl Oct 4, 2023
bfa71b0
test error is not 0 before setting it
etseidl Oct 4, 2023
2cb87d4
Merge branch 'branch-23.12' into detect_header_overrun
etseidl Oct 4, 2023
7b67a1d
error vector does not need to be shared
etseidl Oct 4, 2023
9b943be
add docstring
etseidl Oct 4, 2023
d7b387e
Apply suggestions from code review
etseidl Oct 4, 2023
69bf46b
Merge branch 'branch-23.12' into detect_header_overrun
vuule Oct 5, 2023
fb0e79b
Merge remote-tracking branch 'origin/branch-23.12' into detect_header…
etseidl Oct 9, 2023
3de8283
Merge branch 'branch-23.12' into detect_header_overrun
etseidl Oct 10, 2023
ae2d00c
Merge branch 'branch-23.12' into detect_header_overrun
etseidl Oct 11, 2023
92eb08d
implement change from review
etseidl Oct 13, 2023
e145ecd
a few more review suggestions
etseidl Oct 13, 2023
be49938
Merge branch 'detect_header_overrun' of github.com:etseidl/cudf into …
etseidl Oct 13, 2023
b141c6c
Merge remote-tracking branch 'origin/branch-23.12' into detect_header…
etseidl Oct 13, 2023
12c797c
Apply suggestions from code review
etseidl Oct 16, 2023
be05dbb
Merge remote-tracking branch 'origin/branch-23.12' into detect_header…
etseidl Oct 16, 2023
733efbd
Merge branch 'branch-23.12' into detect_header_overrun
vuule Oct 17, 2023
0a01cef
Merge branch 'branch-23.12' into detect_header_overrun
vuule Oct 20, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'branch-23.12' into detect_header_overrun
etseidl authored Oct 4, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 2cb87d4dc37208ab1cb7441af7da23e1a947036f

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.