Detect and report errors in Parquet header parsing #14237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: we could also detect unsupported encodings earlier, but then that would make addressing #14209 a bit harder. |
|
/ok to test |
vuule
added
cuIO
…detect_header_overrun
vuule
reviewed
Oct 3, 2023
Co-authored-by: Vukasin Milovanovic <[email protected]>
|
/ok to test |
vuule
approved these changes
Oct 4, 2023
Co-authored-by: Vukasin Milovanovic <[email protected]>
|
/ok to test |
|
/ok to test |
bdice
reviewed
Oct 13, 2023
cpp/src/io/parquet/page_hdr.cu
Outdated
| int lane_id = threadIdx.x % 32; | ||
| int chunk = (blockIdx.x * 4) + (threadIdx.x / 32); | ||
| byte_stream_s* const bs = &bs_g[threadIdx.x / 32]; | ||
| int warp_id = threadIdx.x / 32; |
There was a problem hiding this comment.
While refactoring this, let's move to use cudf::detail::warp_size instead of hardcoding 32.
cpp/src/io/parquet/page_hdr.cu
Outdated
| { | ||
| gpuParsePageHeader parse_page_header; | ||
| __shared__ byte_stream_s bs_g[4]; | ||
|
|
||
| int error[4] = {0}; |
There was a problem hiding this comment.
Do we need to be explicit about int vs. int32_t, for the purpose of aligning our conventions? I'd like to use the same type for the error value as the type we use in the parameters of set_error.
Co-authored-by: Bradley Dice <[email protected]>
…detect_header_overrun
|
/ok to test |
bdice
approved these changes
Oct 16, 2023
Co-authored-by: Bradley Dice <[email protected]>
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #13656. Uses the error reporting introduced in #14167 to report errors in header parsing.
Checklist