Add tab as literal to cudf::test::to_string output #13993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
3 - Ready for Review
bdice
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Any other candidates from this list? https://en.wikipedia.org/wiki/Escape_sequences_in_C#Table_of_escape_sequences
Ah, your googling is better than mine. I will add a few more. |
vuule
approved these changes
Aug 29, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds escaped
\\tto thecudf::test::to_string()output.Found this while working on #13891 where the output included tabs but was shown as a various number of spaces in the console when using
cudf::test::print().Also added
\\bfor good measure as well as a gtest for all the supported escape sequences.Checklist