-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BytePairEncoder class to cuDF #13891
Merged
rapids-bot
merged 123 commits into
rapidsai:branch-23.12
from
davidwendt:bpe-python-api
Nov 14, 2023
Merged
Add BytePairEncoder class to cuDF #13891
rapids-bot
merged 123 commits into
rapidsai:branch-23.12
from
davidwendt:bpe-python-api
Nov 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
feature request
New feature or request
2 - In Progress
Currently a work in progress
libcudf
Affects libcudf (C++/CUDA) code.
Python
Affects Python cuDF API.
non-breaking
Non-breaking change
labels
Aug 16, 2023
davidwendt
changed the title
Add BytePairEncoder class to cuDF
Add BytePairEncoder class to cuDF
Aug 16, 2023
davidwendt
changed the title
Add BytePairEncoder class to cuDF
Add BytePairEncoder class to cuDF
Aug 18, 2023
davidwendt
changed the title
Add BytePairEncoder class to cuDF
Add BytePairEncoder class to cuDF
Aug 24, 2023
davidwendt
added
3 - Ready for Review
Ready for review by team
and removed
2 - In Progress
Currently a work in progress
labels
Nov 6, 2023
bdice
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. Requesting one small rename and one docstring summary.
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
CMake
CMake build issue
feature request
New feature or request
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new BytePairEncoding class to cuDF
This class wraps the existing
nvtext::byte_pair_encoding
APIs to load the merge-pairs data and encode a column of strings.Checklist