-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change NA
to NaT
for datetime
and timedelta
types
#13868
Change NA
to NaT
for datetime
and timedelta
types
#13868
Conversation
NA
to NaT
for datetime
and timedelta
types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good overall. I'm a little surprised the changeset isn't larger than this. I would like to think about refactoring the ways we check if values are "None, NA, NaT"-like. I understand it might vary by the calling code, but we might be able to reduce repeated logic a little. If you don't see an opportunity to improve that, I am fine with accepting this PR as-is.
I was able to add |
Co-authored-by: Bradley Dice <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for the iterations.
Co-authored-by: Bradley Dice <[email protected]>
/merge |
Description
Resolves: #13867
This PR:
datetime
&timdelta
types to switch to represent null values asNaT
from<NA>
.cudf.NaT
instead ofcudf.NA
Checklist