Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Change NA to NaT for timedelta & datetime types #13867

Closed
galipremsagar opened this issue Aug 12, 2023 · 0 comments · Fixed by #13868
Closed

[FEA] Change NA to NaT for timedelta & datetime types #13867

galipremsagar opened this issue Aug 12, 2023 · 0 comments · Fixed by #13868
Labels
feature request New feature or request Python Affects Python cuDF API.

Comments

@galipremsagar
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Pandas array with timedelta & datetime types too have NaT as a null value, so this is a feature request to change our <NA> to NaT just for these two types. Also, there are no other null values possible for these type and they don't have a corresponding nullable dtype.

Describe the solution you'd like
Change repr from <NA> to NaT for timedelta64 & datetime64 dtypes.
@galipremsagar galipremsagar added feature request New feature or request Python Affects Python cuDF API. labels Aug 12, 2023
@galipremsagar galipremsagar mentioned this issue Aug 12, 2023
Merged
5 tasks
rapids-bot bot pushed a commit that referenced this issue Aug 14, 2023
@galipremsagar
Change NA to NaT for datetime and timedelta types (#13868)
b768270 
Resolves: #13867 

This PR:

- [x] Changes all repr code of `datetime` & `timdelta` types to switch to represent null values as `NaT` from `<NA>`.
- [x] Changes Scalar getitem to return `cudf.NaT` instead of `cudf.NA`

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #13868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change NA to NaT for datetime and timedelta types galipremsagar/cudf
1 participant
@galipremsagar