Extract debug_utilities.hpp/cu from column_utilities.hpp/cu
#13720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
3 - Ready for Review
|
This looks good. Could you describe the steps to add this to libcudf.so for temporary debugging? |
|
/ok to test |
# Conflicts: # conda/recipes/libcudf/meta.yaml # cpp/tests/utilities/column_utilities.cu
ttnghia
changed the title
cudf::test::print into a separate translation unit and make it independent from gtesttests/column_utilities.* and make them independent from gtest library
|
/ok to test |
|
/ok to test |
davidwendt
reviewed
Oct 18, 2023
bdice
reviewed
Oct 18, 2023
|
/ok to test |
ttnghia
changed the title
tests/column_utilities.* and make them independent from gtest librarytests/debug_utilities.* from tests/column_utilities.*
ttnghia
changed the title
tests/debug_utilities.* from tests/column_utilities.*tests/utilities/debug_utilities.* from tests/utilities/column_utilities.*
ttnghia
changed the title
tests/utilities/debug_utilities.* from tests/utilities/column_utilities.*debug_utilities.hpp/cu from column_utilities.hpp/cu
|
/ok to test |
robertmaynard
approved these changes
Oct 20, 2023
davidwendt
approved these changes
Oct 23, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the implementation of the debug utility function
cudf::test::print()fromcolumn_utilities.hpp/cuinto its separate header/source files (debug_utilities.hpp/cu) for better organizing the relevant code. The new header name is also more expressive and more relevant to its purpose.The changes in this PR are only moving code around. Not any new functionality or implementation was added.
Closes #13450 (although this is not to address that issue).