-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Move cudf::test::print
out of test into a public API
#13450
Comments
I would rather consider a cmake compile option that links the Another option is to use the CSV writer with a |
I have another idea: continue to keep See #13720. |
This PR extracts the implementation of the debug utility function `cudf::test::print()` from `column_utilities.hpp/cu` into its separate header/source files (`debug_utilities.hpp/cu`) for better organizing the relevant code. The new header name is also more expressive and more relevant to its purpose. The changes in this PR are only moving code around. Not any new functionality or implementation was added. Closes #13450 (although this is not to address that issue). Authors: - Nghia Truong (https://github.com/ttnghia) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Robert Maynard (https://github.com/robertmaynard) - David Wendt (https://github.com/davidwendt) URL: #13720
With the growth of libcudf development, there is also an increasing number of debugging tasks. Printing a column content is one of the useful debugging approaches. In cudf, we can easily call
cudf::test::print
for that purpose, but the downstream applications don't have access to such functionality in the C++ test module.I propose to change the function
cudf::test::print
into a public APIcudf::print(column_view const&)
orcudf::to_string(column_view const&)
.The text was updated successfully, but these errors were encountered: