Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support min and max aggregations for list type in groupby and reduction #13676

Merged
merged 22 commits into from
Jul 12, 2023
Merged

Support min and max aggregations for list type in groupby and reduction #13676

merged 22 commits into from
Jul 12, 2023

Conversation

ttnghia
Copy link
Contributor

@ttnghia ttnghia commented Jul 7, 2023 •
edited
Loading

This adds support for list type in min and max aggregations in groupby and reduction contexts.

Closes #13667 and closes #10408.

Status:

@ttnghia ttnghia added feature request New feature or request 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Jul 7, 2023
@ttnghia ttnghia self-assigned this Jul 7, 2023
This was referenced Jul 7, 2023
Closed
Open
@ttnghia ttnghia changed the title Support min and max aggregations for lists type in groupby and reduction Support min and max aggregations for list type in groupby and reduction Jul 11, 2023
@ttnghia ttnghia mentioned this pull request Jul 11, 2023
Merged
@ttnghia ttnghia marked this pull request as ready for review July 11, 2023 19:29
@ttnghia ttnghia requested a review from a team as a code owner July 11, 2023 19:29
@ttnghia ttnghia requested review from bdice, vuule and divyegala July 11, 2023 19:29
@ttnghia ttnghia removed the 2 - In Progress Currently a work in progress label Jul 11, 2023
@ttnghia ttnghia added the 3 - Ready for Review Ready for review by team label Jul 11, 2023
divyegala
divyegala reviewed Jul 11, 2023
View reviewed changes
cpp/src/groupby/hash/groupby.cu Outdated Show resolved Hide resolved
cpp/src/reductions/nested_type_minmax_util.cuh Outdated Show resolved Hide resolved
cpp/src/reductions/nested_type_minmax_util.cuh Outdated Show resolved Hide resolved
cpp/src/reductions/nested_type_minmax_util.cuh Outdated Show resolved Hide resolved
@ttnghia ttnghia requested a review from mythrocks July 12, 2023 00:31
mythrocks
mythrocks approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nitpicks. I appreciate the clarity in the code comments, and the test coverage.

@ttnghia
Copy link
Contributor Author

ttnghia commented Jul 12, 2023

/merge

@rapids-bot rapids-bot bot merged commit 1814ec1 into rapidsai:branch-23.08 Jul 12, 2023
@ttnghia ttnghia deleted the list_min_max branch July 12, 2023 03:40
@GregoryKimball GregoryKimball mentioned this pull request Aug 1, 2023
Closed
@bdice bdice mentioned this pull request Nov 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

@mythrocks mythrocks mythrocks approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@vuule vuule Awaiting requested review from vuule vuule is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@ttnghia ttnghia

Labels
3 - Ready for Review Ready for review by team feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
3 participants
@ttnghia @mythrocks @divyegala