Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support min and max for arrays #8668

Closed
revans2 opened this issue Jul 6, 2023 · 2 comments · Fixed by #8689
Closed

[FEA] Support min and max for arrays #8668

revans2 opened this issue Jul 6, 2023 · 2 comments · Fixed by #8689
Assignees
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request

Comments

@revans2
Copy link
Collaborator

revans2 commented Jul 6, 2023

Is your feature request related to a problem? Please describe.
Some changes went in recently where min and max hash aggregates were added for structs with arrays in them, but not arrays by themselves.

#8638

This covers most of #3153 but does not cover everything we need for a customer. In the short term I can work around it by hacking things up and wrapping the array with a struct. But that is not a good long term solution to the problem.

Describe the solution you'd like
I would like CUDF and us to support group by aggregations for min and max on arrays at the top level.

@ttnghia
Copy link
Collaborator

ttnghia commented Jul 7, 2023

Depends on rapidsai/cudf#13676.

@ttnghia
Copy link
Collaborator

ttnghia commented Jul 8, 2023

BTW, this should be the generalized version of #4929.

@mattahrens mattahrens added cudf_dependency An issue or PR with this label depends on a new feature in cudf and removed ? - Needs Triage Need team to review and classify labels Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants