Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support min/max aggregation/reduction for arrays of structs and arrays of strings #4929

Closed
revans2 opened this issue Mar 10, 2022 · 2 comments · Fixed by #8689
Closed
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request

Comments

@revans2
Copy link
Collaborator

revans2 commented Mar 10, 2022

Is your feature request related to a problem? Please describe.
This is in reference to #4900 specifically the part

!Expression <Min> min(yyyyy#504) cannot run on GPU because expression Min min(xxx#504) produces an unsupported type ArrayType(StructType(StructField(count,LongType,true), StructField(yyy,LongType,true)),true); input expression AttributeReference xxx#504 (ArrayType(StructType(StructField(count,LongType,true), StructField(yyy,LongType,true)),true) is not supported) 

and

!Expression <Min> min(xxx#28) cannot run on GPU because expression Min min(xxx#28) produces an unsupported type ArrayType(StringType,true); input expression AttributeReference xxx#28 (ArrayType(StringType,true) is not supported) 

Describe the solution you'd like
We would like to support at least min aggregations on arrays of structs with basic fields. max would be great to support too, and even better if we can just solve ordering for arrays in the general case. Similarly we would like to do the same for arrays of strings.

Describe alternatives you've considered
In this particular case we could hack something together, but we should not do that.

@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify cudf_dependency An issue or PR with this label depends on a new feature in cudf labels Mar 10, 2022
@revans2
Copy link
Collaborator Author

revans2 commented Mar 10, 2022

This depends on rapidsai/cudf#10408

@revans2 revans2 changed the title [FEA] Support min/max aggregation/reduction for arrays of structs [FEA] Support min/max aggregation/reduction for arrays of structs and arrays of strings Mar 10, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Mar 15, 2022
@ttnghia
Copy link
Collaborator

ttnghia commented Nov 30, 2022

This can be re-prioritized if needed. Cudf dependency is almost done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants