Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libcufile to dependencies.yaml. #13523

Merged
merged 3 commits into from
Jun 9, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jun 7, 2023

Description

This PR adds a libcufile dependency specification, only for x86_64 (the package is not available on ARM). This aligns with the conda recipe specification, previously updated in #13231.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner June 7, 2023 16:14
@bdice bdice self-assigned this Jun 7, 2023
@bdice bdice requested a review from wence- June 7, 2023 16:15
@github-actions github-actions bot added the conda label Jun 7, 2023
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 7, 2023
@bdice
Copy link
Contributor Author

bdice commented Jun 7, 2023

See also: rapidsai/kvikio#237

@bdice
Copy link
Contributor Author

bdice commented Jun 8, 2023

@wence- Please approve and merge this PR once you have had a chance to test it (you mentioned wanting to check for a cufile.log).

dependencies.yaml Show resolved Hide resolved
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the best of my understanding, this DTRT. And it looks like cmake detects the cufile installed with this environment.

@wence-
Copy link
Contributor

wence- commented Jun 9, 2023

/merge

@rapids-bot rapids-bot bot merged commit c49bfd1 into rapidsai:branch-23.08 Jun 9, 2023
@ajschmidt8 ajschmidt8 changed the title Add libcufile to dependencies.yaml. Add libcufile to dependencies.yaml. Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants