-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use libkvikio conda packages in libcudf, add explicit libcufile dependency. #13231
Use libkvikio conda packages in libcudf, add explicit libcufile dependency. #13231
Conversation
Verified that builds show the libkvikio conda package being used on amd64 and arm64.
Also adding the cuFile dependency caused |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @ajschmidt8 -- you requested some changes on cuspatial and ucxx for recent changes to the update-version.sh
script. I started to make those changes here but decided it's too large of a scope for this PR. Also, cudf's update script is significant more complex than ucxx/cuspatial and I didn't want to set the wrong example (since so many packages look to cudf for guidance). If you want this to be updated in the near term, I would appreciate your help!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
There are a lot of process changes I want to make around these scripts in the future.
Realistically I probably won't start that initiative until 23.08
or even 23.10
.
For the record, pip wheels are built with cuFile support. I checked both CUDA 11.8 and CUDA 12.0 builds. AMD64 only, because cuFile isn't supported on ARM64.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, looks good to me :)
This is an important fix for cuFile integration, thank you @bdice !
/merge |
This PR adds a libcufile dependency specification, only for x86_64 (the package is not available on ARM). This aligns with the conda recipe specification, previously updated in #13231. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Lawrence Mitchell (https://github.com/wence-) URL: #13523
Description
Provides a partial solution to #13230. During conda builds of
libcudf
,libkvikio
is currently being fetched by CPM rather than supplied by a conda dependency. This meanslibkvikio
headers are being shipped as part oflibcudf
's packages, which is not desirable.I also added
libcufile[-dev]
as an explicit dependency of libcudf. Note that this is only available on linux64 (amd64), not aarch64 (arm64). We should always make the cuFile library available at build time for conda packages on amd64.The impacts of this change are:
libcudf
conda packages will no longer shiplibkvikio
headers (those headers will instead be supplied bylibkvikio
packages). This reduces the size of libcudf and prevents clobbering files fromlibkvikio
.libcudf
will have a dependency onlibcufile
from thenvidia
channel onlinux64
(but notaarch64
, since libcufile packages currently do not exist foraarch64
).This change does not impact builds outside of conda-build.
Checklist