Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require numba >= 0.57 #13395

Closed
wants to merge 3 commits into from
Closed

Require numba >= 0.57 #13395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea2e97c
upgrade to numba 0.57
brandon-b-miller May 19, 2023
7c141e2
use yaml anchor
brandon-b-miller May 19, 2023
eb346ce
update apply_wheel_modifications.sh
brandon-b-miller May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ci/release/apply_wheel_modifications.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ sed -i "s/\"cudf==/\"cudf${CUDA_SUFFIX}==/g" python/dask_cudf/pyproject.toml
if [[ $CUDA_SUFFIX == "-cu12" ]]; then
sed -i "s/cuda-python[<=>\.,0-9]*/cuda-python>=12.0,<13.0/g" python/cudf/pyproject.toml
sed -i "s/cupy-cuda11x/cupy-cuda12x/g" python/{cudf,dask_cudf}/pyproject.toml
sed -i "s/numba[<=>\.,0-9]*/numba>=0.57/g" python/{cudf,dask_cudf}/pyproject.toml
sed -i "/ptxcompiler/d" python/cudf/pyproject.toml
sed -i "/cubinlinker/d" python/cudf/pyproject.toml
fi
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-118_arch-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ dependencies:
- nbsphinx
- ninja
- notebook
- numba>=0.56.4,<0.57
- numba>=0.57
- numpy>=1.21,<1.24
- numpydoc
- nvcc_linux-64=11.8
Expand Down
4 changes: 2 additions & 2 deletions conda/recipes/cudf/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ requirements:
- cython >=0.29,<0.30
- scikit-build >=0.13.1
- setuptools
- numba >=0.56.4,<0.57
- numba >=0.57
Copy link
Contributor

@bdice bdice May 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is numba actually a build-time requirement (typically this means it is needed by Cython as a cimport), or only a run-time requirement? It's not listed in [build-system.requires] for wheels. If not, please remove.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dealt with this separately in #13406, since it looks like this PR might be closed in favor of #13337.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdice . Just leaving this open for now in case something weird happens but I do strongly suspect that as you say, we will close this one.

- dlpack >=0.5,<0.6.0a0
- pyarrow =11
- libcudf ={{ version }}
Expand All @@ -65,7 +65,7 @@ requirements:
- typing_extensions
- pandas >=1.3,<1.6.0dev0
- cupy >=12.0.0
- numba >=0.56.4,<0.57
- numba >=0.57
- numpy >=1.21,<1.24 # Temporarily upper bound numpy to avoid overflow deprecations
- {{ pin_compatible('pyarrow', max_pin='x.x.x') }}
- libcudf {{ version }}
Expand Down
2 changes: 1 addition & 1 deletion dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ dependencies:
packages:
- cachetools
- cuda-python>=11.7.1,<12.0
- &numba numba>=0.56.4,<0.57
- &numba numba>=0.57
- nvtx>=0.2.1
- packaging
- rmm==23.6.*
Expand Down
2 changes: 1 addition & 1 deletion python/cudf/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ dependencies = [
"cuda-python>=11.7.1,<12.0",
"cupy-cuda11x>=12.0.0",
"fsspec>=0.6.0",
"numba>=0.56.4,<0.57",
"numba>=0.57",
"numpy>=1.21,<1.24",
"nvtx>=0.2.1",
"packaging",
Expand Down
2 changes: 1 addition & 1 deletion python/dask_cudf/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ dynamic = ["entry-points"]
[project.optional-dependencies]
test = [
"dask-cuda==23.6.*",
"numba>=0.56.4,<0.57",
"numba>=0.57",
"pytest",
"pytest-cov",
"pytest-xdist",
Expand Down