-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require numba >= 0.57 #13395
Require numba >= 0.57 #13395
Conversation
dependencies.yaml
Outdated
@@ -507,4 +507,4 @@ dependencies: | |||
- output_types: [conda, requirements, pyproject] | |||
packages: | |||
- dask-cuda==23.6.* | |||
- *numba | |||
- numba>=0.57 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave this *numba
as it was, and use &numba
above. That uses a YAML anchor to enforce that the value is copied.
Please also remove this line:
|
@@ -53,7 +53,7 @@ requirements: | |||
- cython >=0.29,<0.30 | |||
- scikit-build >=0.13.1 | |||
- setuptools | |||
- numba >=0.56.4,<0.57 | |||
- numba >=0.57 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is numba actually a build-time requirement (typically this means it is needed by Cython as a cimport
), or only a run-time requirement? It's not listed in [build-system.requires]
for wheels. If not, please remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bdice . Just leaving this open for now in case something weird happens but I do strongly suspect that as you say, we will close this one.
The notebooks tests seemed to have failed because they didn't get the latest ptxcompiler - it looks like 0.7.0 came from the rapidsai-nightly channel:
I'm surprised we have ptxcompiler packages in this channel at all - is there a reason we don't just get them from conda-forge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me (assuming CI eventually passes once the right ptxcompiler packages are picked up)
Closing in favor of PR ( #13337 ) Changes from that PR are needed to resolve the errors seen here |
This PR sets the lower bound for
numba
to version 0.57.