Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require numba >= 0.57 #13395

Closed

Conversation

brandon-b-miller
Copy link
Contributor

This PR sets the lower bound for numba to version 0.57.

@brandon-b-miller brandon-b-miller requested review from a team as code owners May 19, 2023 21:24
@brandon-b-miller brandon-b-miller requested review from wence- and vyasr May 19, 2023 21:24
@github-actions github-actions bot added conda Python Affects Python cuDF API. labels May 19, 2023
@brandon-b-miller brandon-b-miller added feature request New feature or request non-breaking Non-breaking change labels May 19, 2023
@@ -507,4 +507,4 @@ dependencies:
- output_types: [conda, requirements, pyproject]
packages:
- dask-cuda==23.6.*
- *numba
- numba>=0.57
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave this *numba as it was, and use &numba above. That uses a YAML anchor to enforce that the value is copied.

@bdice
Copy link
Contributor

bdice commented May 19, 2023

Please also remove this line:

sed -i "s/numba[<=>\.,0-9]*/numba>=0.57/g" python/{cudf,dask_cudf}/pyproject.toml

@github-actions github-actions bot added the ci label May 19, 2023
@jakirkham jakirkham requested a review from bdice May 19, 2023 21:35
@@ -53,7 +53,7 @@ requirements:
- cython >=0.29,<0.30
- scikit-build >=0.13.1
- setuptools
- numba >=0.56.4,<0.57
- numba >=0.57
Copy link
Contributor

@bdice bdice May 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is numba actually a build-time requirement (typically this means it is needed by Cython as a cimport), or only a run-time requirement? It's not listed in [build-system.requires] for wheels. If not, please remove.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dealt with this separately in #13406, since it looks like this PR might be closed in favor of #13337.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdice . Just leaving this open for now in case something weird happens but I do strongly suspect that as you say, we will close this one.

@gmarkall
Copy link
Contributor

The notebooks tests seemed to have failed because they didn't get the latest ptxcompiler - it looks like 0.7.0 came from the rapidsai-nightly channel:

   + ptxcompiler                0.7.0  cuda_11_py310_gaec9cc8_44            rapidsai-nightly/linux-64           6MB

I'm surprised we have ptxcompiler packages in this channel at all - is there a reason we don't just get them from conda-forge?

Copy link
Contributor

@gmarkall gmarkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me (assuming CI eventually passes once the right ptxcompiler packages are picked up)

@jakirkham
Copy link
Member

jakirkham commented May 22, 2023

Closing in favor of PR ( #13337 )

Changes from that PR are needed to resolve the errors seen here

@jakirkham jakirkham closed this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants