Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix approach to detecting assignment for gte/lte operators #13285

Merged
merged 3 commits into from
May 11, 2023
Merged

Fix approach to detecting assignment for gte/lte operators #13285

merged 3 commits into from
May 11, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented May 4, 2023

Description

Resolves #13185

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change python labels May 4, 2023
@vyasr vyasr requested a review from a team as a code owner May 4, 2023 00:07
@vyasr vyasr self-assigned this May 4, 2023
@vyasr vyasr requested review from bdice and isVoid May 4, 2023 00:07
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 4, 2023
@vyasr
Copy link
Contributor Author

vyasr commented May 4, 2023

CC @karthikeyann

@vyasr vyasr requested a review from bdice May 9, 2023 00:35
@vyasr
Copy link
Contributor Author

vyasr commented May 11, 2023

/merge

@rapids-bot rapids-bot bot merged commit deaba97 into rapidsai:branch-23.06 May 11, 2023
@vyasr vyasr deleted the fix/eval_assignment_detection branch May 11, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] cuDF expression evaluation of some comparison operators creates AssertionError
2 participants
@vyasr @bdice