Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] cuDF expression evaluation of some comparison operators creates AssertionError #13185

Closed
karthikeyann opened this issue Apr 20, 2023 · 1 comment · Fixed by #13285
Closed
Labels
bug Something isn't working

Comments

@karthikeyann
Copy link
Contributor

Describe the bug
cuDF expression evaluation created AssertionError for less equal, greater equal and not equal operators.

Steps/Code to reproduce bug

import cudf
df = cudf.DataFrame({'a': 1, 'b': 's'})
df.to_pandas().eval("a>=2")
df.to_pandas().eval("a<=2")
df.to_pandas().eval("a!=2")

#these statements error ou
df.eval("a>=2")
df.eval("a<=2")
df.eval("a!=2")
@karthikeyann karthikeyann added bug Something isn't working Needs Triage Need team to review and classify labels Apr 20, 2023
@vyasr
Copy link
Contributor

vyasr commented May 4, 2023

The problem is this line of code that is using a regex to search for an assignment operator. It correctly filters out ==, but is not currently aware of >= or <=. Adding those to characters to the excluded character classes should fix the issue.

rapids-bot bot pushed a commit that referenced this issue May 11, 2023
@bdice bdice removed the Needs Triage Need team to review and classify label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants