JNI api for cudf::chunked_pack #13278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <[email protected]>
abellina
added
Spark
revans2
reviewed
May 3, 2023
| * JNI interface to cudf::chunked_pack. | ||
| * | ||
| * ChunkedPack is an iterator-like interface with the familiar `hasNext` and `next` | ||
| * interface. `next` should be used in a loop until `hasNext` returns false. |
There was a problem hiding this comment.
nit: can we say more like
`ChunkedPack` has an Iterator-like API with the familiar `hasNext` and `next` methods.
| return true; | ||
| } | ||
|
|
||
| jobject packed_column_metadata_from(JNIEnv *env, std::unique_ptr<std::vector<uint8_t>> meta) { |
There was a problem hiding this comment.
Why do we create a jobect and do all of the reflection/etc if we could just return a jlong to java and let it call the constructor in java?
There was a problem hiding this comment.
yeap that is much easier, fixed.
revans2
approved these changes
May 8, 2023
ttnghia
approved these changes
May 18, 2023
revans2
approved these changes
May 18, 2023
java/src/main/native/src/CudfJni.cpp
Outdated
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2019-2022, NVIDIA CORPORATION. | |||
| * Copyright (c) 2019-2023, NVIDIA CORPORATION. | |||
There was a problem hiding this comment.
Is this needed? We are only changing the copyright date???
There was a problem hiding this comment.
Sorry about that, it is fixed now.
| @@ -51,7 +51,6 @@ convert_table_for_return(JNIEnv *env, std::unique_ptr<cudf::table> &&table_resul | |||
| // | |||
|
|
|||
| bool cache_contiguous_table_jni(JNIEnv *env); | |||
|
|
|||
There was a problem hiding this comment.
why is this change needed?
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the standalone JNI side of #13260. Therefore it doesn't build in as is, but I am putting this up as draft for the Java reviewers to start taking a look.
This implements a
ChunkedPackjava class mirroring the interface ofcudf::chunked_pack. This is an iterator-like class that can be used to invokecudf::pack(akacudf::contigous_splitwithout splits) over several iterations against a bounce buffer.In order to create a
ChunkedPack, the user callsmakeChunkedPackfrom aTableinstance. During this call the user can also pass anRmmDeviceMemoryResourceto be used internally bycudf::chunked_packexclusively for scratch/temporary data.Checklist