-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tables spillable by default #8264
Conversation
Signed-off-by: Alessandro Bellina <[email protected]>
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsBufferCatalog.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits and comment requests. But I want to spend some more time looking at the tests.
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuDeviceManager.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuDeviceManager.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsBuffer.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsBufferCatalog.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsDeviceMemoryStore.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsDeviceMemoryStore.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsHostMemoryStore.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/stringFunctions.scala
Outdated
Show resolved
Hide resolved
tests/src/test/scala/com/nvidia/spark/rapids/RmmSparkRetrySuiteBase.scala
Show resolved
Hide resolved
Updating the full NDS benchmark with rapidsai/cudf#13260 + rapidsai/cudf#13278 + #8264 (this), I am seeing a ~4% improvement vs the last nightly. I looked at one of the queries (q95) which becomes ~14% faster. Before the change ~7% of kernel time was spent in this function, whereas now it's less than 0.1%.
|
working on review comments locally and will push but this won't be merge-able until Monday. |
build |
build |
build |
Ok, @revans2 the reason for c3c2179 was a change I had made in the test locally and forgotten to undo it. It should be a single close because the code throws a retry and split within a retry (this tests the specific exception), and so every batch that was open was told to close. I do not remember why I had changed this locally, but overall it removes the whole file from the unit test changes. |
Closes #7672
This depends on rapidsai/cudf#13260 (rapidsai/cudf#13180 overarching issue)
The idea behind this is to be able to add a
Table
as an object into the spillable store. TheTable
will not be made contiguous until that is needed at spill time (to host memory), which is done usingchunked_pack
. Once it has gone throughchunked_pack
the table will be reconstituted as a regularRapidsDeviceMemoryBuffer
with a single contiguous allocation.It is draft because I still need to clean it up some and I need to add unit tests specific to this scenario. I also did a bunch of cleanup today and I have not run the latest, so I could have bugs here. But nevertheless, I think it is worth starting to take a look at it.
It won't pass the build because the cuDF PRs are not in yet, and I have one test failure that I know of.