Fix structs_column_wrapper constructors to copy input column wrappers #13243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
cudf::test::structs_column_wrapper
constructors that acceptcolumn_wrapper
instances to copy the underlying column rather than move it. The constructor signatures do not provide any indication that the passed wrappers will be destroyed. Also, the other nested column wrapper constructors make copies unless the parameters are decorated with move declarations (i.e.&&
).Closes #13200
Checklist