Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix structs_column_wrapper constructors to copy input column wrappers #13243

Merged

Conversation

davidwendt
Copy link
Contributor

Description

Fixes the cudf::test::structs_column_wrapper constructors that accept column_wrapper instances to copy the underlying column rather than move it. The constructor signatures do not provide any indication that the passed wrappers will be destroyed. Also, the other nested column wrapper constructors make copies unless the parameters are decorated with move declarations (i.e. &&).

Closes #13200

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Apr 28, 2023
@davidwendt davidwendt self-assigned this Apr 28, 2023
@davidwendt davidwendt requested a review from a team as a code owner April 28, 2023 00:21
@davidwendt davidwendt requested review from bdice and nvdbaranec April 28, 2023 00:21
@davidwendt davidwendt changed the title Fix structs_column_wrapper ctors to copy input column wrappers Fix structs_column_wrapper constructors to copy input column wrappers Apr 28, 2023
Copy link
Contributor

@nvdbaranec nvdbaranec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. There is a -lot- of test code out there that has to do some ugly code jiggling to get around this.

@vyasr
Copy link
Contributor

vyasr commented May 1, 2023

This is great. There is a -lot- of test code out there that has to do some ugly code jiggling to get around this.

@nvdbaranec should we open an issue to track that cleanup? Not a high priority task, but it would be nice to know it could be done (I don't have the context for these tests but it sounds like you have some in mind?).

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 421ac67 into rapidsai:branch-23.06 May 2, 2023
@davidwendt davidwendt deleted the bug-structs-col-wrapper branch May 2, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cudf::test::print seg faults on nested structs
4 participants