-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] cudf::test::print
seg faults on nested structs
#13200
Comments
This is not a bug, but rather a feature 😛 At this line, the content of |
I think that taking ownership of the parameters in this case is unexpected and the constructor should be copying the wrapper data instead of moving it.
Created PR #13243 to fix this. |
…#13243) Fixes the `cudf::test::structs_column_wrapper` constructors that accept `column_wrapper` instances to copy the underlying column rather than move it. The constructor signatures do not provide any indication that the passed wrappers will be destroyed. Also, the other nested column wrapper constructors make copies unless the parameters are decorated with move declarations (i.e. `&&`). Closes #13200 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Nghia Truong (https://github.com/ttnghia) - https://github.com/nvdbaranec URL: #13243
Describe the bug
When used to print out nested structs, the
cudf::test::print
utility triggers a segmentation fault rather than printing in some cases.Steps/Code to reproduce bug
Add these two lines:
just before this assertion in the
NestedStruct_Sliced
test. The result should be fine, until the second line is commented out. Then the code will seg fault.Expected behavior
No seg fault
The text was updated successfully, but these errors were encountered: