Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scalar argtypes to udf cache keys #13194

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Add scalar argtypes to udf cache keys #13194

merged 3 commits into from
Apr 26, 2023

Conversation

brandon-b-miller
Copy link
Contributor

Closes #13193

@brandon-b-miller brandon-b-miller added bug Something isn't working non-breaking Non-breaking change python labels Apr 21, 2023
@brandon-b-miller brandon-b-miller requested a review from a team as a code owner April 21, 2023 14:44
@brandon-b-miller brandon-b-miller self-assigned this Apr 21, 2023
@github-actions github-actions bot added the Python Affects Python cuDF API. label Apr 21, 2023
@brandon-b-miller brandon-b-miller added the 3 - Ready for Review Ready for review by team label Apr 24, 2023
@brandon-b-miller
Copy link
Contributor Author

@gpucibot merge

@rapids-bot
Copy link

rapids-bot bot commented Apr 26, 2023

@brandon-b-miller, the @gpucibot merge command has been replaced with /merge.

Please re-comment this PR with /merge and use this new command in the future.

@brandon-b-miller
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit bd04975 into rapidsai:branch-23.06 Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@bdice bdice bdice approved these changes

@skirui-source skirui-source Awaiting requested review from skirui-source skirui-source is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@brandon-b-miller brandon-b-miller

Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Changing the type of a scalar arg in a UDF results in an erroneous cache hit
3 participants
@brandon-b-miller @bdice @galipremsagar