Pre-emptive fix for upstream dask.dataframe.read_parquet changes
#12983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/cudf into preserve-int-partitions
rjzamora
added
bug
rjzamora
commented
Mar 21, 2023
Comment on lines
+124
to
+125
| dataset_kwargs=dataset_kwargs, | ||
| categorical_partitions=False, |
There was a problem hiding this comment.
Fixing minor mistake in #12756 (these args should match those used in the try block)
rjzamora
added
3 - Ready for Review
wence-
approved these changes
Mar 23, 2023
rjzamora
added
5 - Ready to Merge
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Once dask/dask#10007 is merged, users will be able to pass a dictionary of hive-partitioning options to
dd.read_parquet(using thedataset=kwarg). This new feature provides a workaround for the fact thatpyarrow.dataset.Partitioningobjects cannot be serialized in Python. In order for this feature to be supported indask_cudftheCudfEngine.read_partitionmethod must account for the case thatpartitioningis adict.NOTE:
It is not possible to add test coverage for this change until dask#10007 is merged. However, I don't see any good reason not to merge this PR before dask#10007.
Checklist