Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add try/except for expected null-schema error in read_parquet #12756

Merged
merged 17 commits into from
Mar 8, 2023
Merged

Add try/except for expected null-schema error in read_parquet #12756

merged 17 commits into from
Mar 8, 2023

Conversation

rjzamora
Copy link
Member

@rjzamora rjzamora commented Feb 10, 2023 •
edited
Loading

Description

Temporary workaround for #12702 - Adds a try/except to concatenate distinct cudf.read_parquet results instead of requiring file aggregation to occur within libcudf.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added bug Something isn't working 2 - In Progress Currently a work in progress dask Dask issue non-breaking Non-breaking change labels Feb 10, 2023
@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 10, 2023
@rjzamora rjzamora marked this pull request as ready for review February 13, 2023 15:58
@rjzamora rjzamora requested a review from a team as a code owner February 13, 2023 15:58
@rjzamora rjzamora added 3 - Ready for Review Ready for review by team 4 - Needs Dask Reviewer and removed 2 - In Progress Currently a work in progress labels Feb 13, 2023
@rjzamora rjzamora changed the title [WIP] Add try/except for expected null-schema error in read_parquet Add try/except for expected null-schema error in read_parquet Feb 28, 2023
wence-
wence- requested changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test that the test is successful please? Otherwise looks good.

python/dask_cudf/dask_cudf/io/tests/test_parquet.py Outdated Show resolved Hide resolved
@rjzamora rjzamora requested a review from wence- March 7, 2023 18:53
wence-
wence- approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wence-
Copy link
Contributor

wence- commented Mar 8, 2023

/merge

@rjzamora rjzamora added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Dask Reviewer labels Mar 8, 2023
@rapids-bot rapids-bot bot merged commit ef9780f into rapidsai:branch-23.04 Mar 8, 2023
@rjzamora rjzamora deleted the catch-null-schema-error branch March 8, 2023 22:53
@rjzamora rjzamora mentioned this pull request Mar 21, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working dask Dask issue non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjzamora @wence-