Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate parquet encoding to use experimental row operators #12918

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Migrate parquet encoding to use experimental row operators #12918

merged 2 commits into from
Mar 10, 2023

Conversation

PointKernel
Copy link
Member

Description

Contributes to #11844

This PR migrates parquet encoding to use the experimental nan_equal equality check instead of the legacy equality_compare.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 9, 2023
@PointKernel PointKernel requested a review from divyegala March 9, 2023 23:05
@PointKernel PointKernel requested a review from a team as a code owner March 9, 2023 23:05
@PointKernel PointKernel self-assigned this Mar 9, 2023
@PointKernel PointKernel requested a review from davidwendt March 9, 2023 23:05
@PointKernel PointKernel mentioned this pull request Mar 9, 2023
Closed
davidwendt
davidwendt approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PointKernel
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 697d78a into rapidsai:branch-23.04 Mar 10, 2023
@PointKernel PointKernel deleted the parquet-new-row-operators branch March 10, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@divyegala divyegala divyegala approved these changes

@ttnghia ttnghia ttnghia approved these changes

Assignees

@PointKernel PointKernel

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PointKernel @ttnghia @divyegala @davidwendt