Skip to content

Commit

Permalink
Migrate parquet encoding to use experimental row operators (#12918)
Browse files Browse the repository at this point in the history
Contributes to #11844

This PR migrates parquet encoding to use the experimental `nan_equal` equality check instead of the legacy `equality_compare`.

Authors:
  - Yunsong Wang (https://github.com/PointKernel)

Approvers:
  - David Wendt (https://github.com/davidwendt)
  - Nghia Truong (https://github.com/ttnghia)
  - Divye Gala (https://github.com/divyegala)

URL: #12918
  • Loading branch information
PointKernel authored Mar 10, 2023
1 parent e4557cb commit 697d78a
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions cpp/src/io/parquet/chunk_dict.cu
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

#include <cudf/detail/iterator.cuh>
#include <cudf/detail/utilities/cuda.cuh>
#include <cudf/table/row_operators.cuh>
#include <cudf/table/experimental/row_operators.cuh>

#include <rmm/exec_policy.hpp>

Expand Down Expand Up @@ -53,7 +53,8 @@ struct equality_functor {
__device__ bool operator()(size_type lhs_idx, size_type rhs_idx)
{
// We don't call this for nulls so this is fine
return equality_compare(col.element<T>(lhs_idx), col.element<T>(rhs_idx));
auto const equal = cudf::experimental::row::equality::nan_equal_physical_equality_comparator{};
return equal(col.element<T>(lhs_idx), col.element<T>(rhs_idx));
}
};

Expand Down

0 comments on commit 697d78a

Please sign in to comment.