Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.7 handling for pickle protocol 4 #12857

Merged
merged 6 commits into from
Mar 9, 2023
Merged

Drop Python 3.7 handling for pickle protocol 4 #12857

merged 6 commits into from
Mar 9, 2023

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Feb 27, 2023 •
edited
Loading

Description

Fixes #12851

Now that Python 3.8 is the minimum supported version, drop the special casing for Python 3.7's HIGHEST_PROTOCOL, which was 4 (not 5). In Python 3.8+, HIGHEST_PROTOCOL >= 5. So none of these branches are needed any more.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jakirkham
Drop Python 3.7 handling for pickle protocol 4
0448029 
Now that Python 3.8 is the minimum supported version, drop the special
casing for Python 3.7's `HIGHEST_PROTOCOL`, which was 4 (not 5). In
Python 3.8+, `HIGHEST_PROTOCOL >= 5`. So none of these branches are
needed any more.
@jakirkham jakirkham requested a review from a team as a code owner February 27, 2023 21:38
@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 27, 2023
@jakirkham jakirkham added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 27, 2023
@jakirkham
Copy link
Member Author

cc @bdice

@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit ea62e0e into rapidsai:branch-23.04 Mar 9, 2023
@jakirkham jakirkham deleted the drop_py37_pkl_4_checks branch March 9, 2023 16:10
@jakirkham
Copy link
Member Author

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@bdice bdice bdice approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop pickle.HIGHEST_PROTOCOL >=5 branches
4 participants
@jakirkham @galipremsagar @bdice @shwina