Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop pickle.HIGHEST_PROTOCOL >=5 branches #12851

Closed
jakirkham opened this issue Feb 24, 2023 · 0 comments · Fixed by #12857
Closed

Drop pickle.HIGHEST_PROTOCOL >=5 branches #12851

jakirkham opened this issue Feb 24, 2023 · 0 comments · Fixed by #12857

Comments

@jakirkham
Copy link
Member

As Python 3.8 is the oldest version of Python cuDF supports and pickle.HIGHEST_PROTOCOL=5 in Python 3.8+ (at least until a new pickle protocol comes along), all the pickle.HIGHEST_PROTOCOL >=5 checks are True. Would recommend dropping these checks and just run the code included in them

cudf/python/cudf/cudf/tests/test_pickling.py

Line 28 in d14d980

if pickle.HIGHEST_PROTOCOL >= 5:

cudf/python/cudf/cudf/tests/test_pack.py

Line 194 in d14d980

if pickle.HIGHEST_PROTOCOL >= 5:

@jakirkham jakirkham mentioned this issue Feb 27, 2023
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Mar 9, 2023
@jakirkham
Drop Python 3.7 handling for pickle protocol 4 (#12857)
ea62e0e 
Fixes #12851

Now that Python 3.8 is the minimum supported version, drop the special casing for Python 3.7's `HIGHEST_PROTOCOL`, which was 4 (not 5). In Python 3.8+, `HIGHEST_PROTOCOL >= 5`. So none of these branches are needed any more.

Authors:
  - https://github.com/jakirkham
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Ashwin Srinath (https://github.com/shwina)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Bradley Dice (https://github.com/bdice)

URL: #12857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop Python 3.7 handling for pickle protocol 4 jakirkham/cudf
1 participant
@jakirkham