Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace nbtest with nbval. #12849

Closed
wants to merge 1 commit into from
+6 −246
Closed

Replace nbtest with nbval. #12849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 2 additions & 30 deletions ci/test_notebooks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,33 +29,5 @@ rapids-mamba-retry install \
--channel "${PYTHON_CHANNEL}" \
cudf libcudf

NBTEST="$(realpath "$(dirname "$0")/utils/nbtest.sh")"
pushd notebooks

# Add notebooks that should be skipped here
# (space-separated list of filenames without paths)
SKIPNBS=""

EXITCODE=0
trap "EXITCODE=1" ERR
set +e
for nb in $(find . -name "*.ipynb"); do
nbBasename=$(basename ${nb})
# Skip all notebooks that use dask (in the code or even in their name)
if ((echo ${nb} | grep -qi dask) || \
(grep -q dask ${nb})); then
echo "--------------------------------------------------------------------------------"
echo "SKIPPING: ${nb} (suspected Dask usage, not currently automatable)"
echo "--------------------------------------------------------------------------------"
elif (echo " ${SKIPNBS} " | grep -q " ${nbBasename} "); then
echo "--------------------------------------------------------------------------------"
echo "SKIPPING: ${nb} (listed in skip list)"
echo "--------------------------------------------------------------------------------"
else
nvidia-smi
${NBTEST} ${nbBasename}
fi
done

rapids-logger "Test script exiting with value: $EXITCODE"
exit ${EXITCODE}
# Run all notebooks with nbval
python -m pytest -v --nbval --nbval-lax notebooks/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to exclude notebooks directory? Because the performance notebook being added in #12595 will require state-of-the-art hardware hence it is not fit to be run in CI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ll look at how to do exclusions soon. We didn’t run dask notebooks with the old method, so I’ll investigate how to align with that.

For curiosity, what is the approximate runtime of the performance notebook @galipremsagar ?

Copy link
Contributor

@galipremsagar galipremsagar Feb 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hours(~3) on H100, primarily because of CPU parts. GPU parts finish quickly (Max 1-2 mins?).

53 changes: 0 additions & 53 deletions ci/utils/nbtest.sh
View file
Open in desktop

This file was deleted.

163 changes: 0 additions & 163 deletions ci/utils/nbtestlog2junitxml.py
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions conda/environments/all_cuda-118_arch-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ dependencies:
- moto>=4.0.8
- myst-nb
- nbsphinx
- nbval
- ninja
- notebook
- numba>=0.56.2
Expand Down
3 changes: 3 additions & 0 deletions dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,10 @@ dependencies:
- output_types: [conda, requirements]
packages:
- ipython
- nbval
- notebook
- pytest
- pytest-xdist
- scipy
py_version:
specific:
Expand Down