Replace nbtest with nbval. #12849
Replace nbtest with nbval. #12849
Conversation
| rapids-logger "Test script exiting with value: $EXITCODE" | ||
| exit ${EXITCODE} | ||
| # Run all notebooks with nbval | ||
| python -m pytest -v --nbval --nbval-lax notebooks/ |
There was a problem hiding this comment.
Is it possible to exclude notebooks directory? Because the performance notebook being added in #12595 will require state-of-the-art hardware hence it is not fit to be run in CI.
There was a problem hiding this comment.
I’ll look at how to do exclusions soon. We didn’t run dask notebooks with the old method, so I’ll investigate how to align with that.
For curiosity, what is the approximate runtime of the performance notebook @galipremsagar ?
There was a problem hiding this comment.
hours(~3) on H100, primarily because of CPU parts. GPU parts finish quickly (Max 1-2 mins?).
|
@bdice do you still want to pursue this? The package has been quiet for about a year now, but maybe it's widely used enough that we can still rely on the community keeping it afloat. |
|
Nope. I agree that nbval is not as active as nbtest. I thought the pytest integration of nbval could be nice, but it's not worth changing. I'll close this. |
Description
This PR replaces the
nbtestnotebook testing shell scripts with a simpler package nbval that integrates with pytest to run notebooks. This allows us to get rid of a fair amount of code and also get more helpful CI outputs.Checklist