Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compute-sanitizer github workflow action to nightly tests #12800

Merged
merged 20 commits into from
Feb 23, 2023
Merged

Add compute-sanitizer github workflow action to nightly tests #12800

merged 20 commits into from
Feb 23, 2023

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Feb 17, 2023 •
edited
Loading

Description

Adds github workflow action to the nightly tests for running compute-sanitizer on the libcudf gtests.

Reference: #12530

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress gpuCI libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 17, 2023
@davidwendt davidwendt self-assigned this Feb 17, 2023
@github-actions github-actions bot added ci and removed libcudf Affects libcudf (C++/CUDA) code. labels Feb 17, 2023
@davidwendt davidwendt mentioned this pull request Feb 17, 2023
Merged
3 tasks
davidwendt
davidwendt commented Feb 17, 2023
View reviewed changes
ci/test_cpp_memcheck.sh Outdated Show resolved Hide resolved
ajschmidt8
ajschmidt8 reviewed Feb 17, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments.

Looks great otherwise.

Nice job Dave.

ci/test_cpp_memcheck.sh Outdated Show resolved Hide resolved
ci/test_cpp_memcheck.sh Outdated Show resolved Hide resolved
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Feb 21, 2023
@davidwendt davidwendt added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Feb 21, 2023
@davidwendt davidwendt removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Feb 22, 2023
@github-actions github-actions bot removed the libcudf Affects libcudf (C++/CUDA) code. label Feb 22, 2023
@davidwendt davidwendt marked this pull request as ready for review February 22, 2023 17:39
@davidwendt davidwendt requested a review from a team as a code owner February 22, 2023 17:39
vyasr
vyasr approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor suggestions, but nothing blocking. Feel free to resolve as you see fit. Excited to have this running again!

ci/test_cpp.sh Show resolved Hide resolved
ci/test_cpp_memcheck.sh Outdated Show resolved Hide resolved
ci/test_cpp_memcheck.sh Outdated Show resolved Hide resolved
ci/test_cpp_memcheck.sh Show resolved Hide resolved
dependencies.yaml Show resolved Hide resolved
bdice
bdice approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, aside from @vyasr's suggestions.

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit fffdc0c into rapidsai:branch-23.04 Feb 23, 2023
@davidwendt davidwendt deleted the gha-compute-sanitizer branch February 23, 2023 01:53
@bdice bdice mentioned this pull request Mar 2, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr vyasr approved these changes

Assignees

@davidwendt davidwendt

Labels
2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @vyasr @bdice @ajschmidt8